Skip to content

Commit

Permalink
coreos-boot-edit: add triggering condition on coreos-copy-firstboot-n…
Browse files Browse the repository at this point in the history
…etwork.stamp

That way we completely avoid mounting `/boot` rw if we don't need to.
Also clarify comment about the boot dependency. Additional roles for
this service ideally would follow the same pattern.

Minor follow-up to coreos#743.
  • Loading branch information
jlebon committed Nov 23, 2020
1 parent 993697e commit 1ba7e94
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,13 @@ ConditionPathExists=/usr/lib/initrd-release
OnFailure=emergency.target
OnFailureJobMode=isolate

# Since we are mounting /boot, require the device first
# These are the conditions for which we may need to modify /boot. Otherwise,
# let's avoid mounting it entirely.
# Currently, we only have one trigger.
ConditionPathExists=|/run/coreos-copy-firstboot-network.stamp

# Since we are mounting /boot, require the device first. This isn't strictly
# necessary since we run late, but on principle let's make clear the dependency.
Requires=dev-disk-by\x2dlabel-boot.device
After=dev-disk-by\x2dlabel-boot.device
# Start after Ignition has finished
Expand Down

0 comments on commit 1ba7e94

Please sign in to comment.