Improve selection of cluster #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My work is not finished, but it starts working:
|
angelozerr
force-pushed
the
select-cluster
branch
3 times, most recently
from
ba88c1a to
7c9439c
Compare
angelozerr
commented
Jan 14, 2021
| @@ -48,6 +48,11 @@ export class Icons { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| export enum GlyphChars { | |||
| Check = '\u2713' | |||
There was a problem hiding this comment.
Just for information, the idea of GlyphChars comes from the vscode-gitlens https://github.com/eamodio/vscode-gitlens/blob/7f549c66e7ade7c569f5acd906d170646d7ab5d9/src/views/nodes/branchNode.ts#L392
angelozerr
force-pushed
the
select-cluster
branch
from
7c9439c to
5cffb91
Compare
|
The PR can be reviewed, it shows the selected cluster is the tree and manage too the enable/disable of
|
angelozerr
force-pushed
the
select-cluster
branch
from
5cffb91 to
b6c0df3
Compare
fbricon
reviewed
Jan 18, 2021
angelozerr
force-pushed
the
select-cluster
branch
from
b6c0df3 to
f896c48
Compare
fbricon
reviewed
Jan 19, 2021
fbricon
approved these changes
Jan 19, 2021
angelozerr
force-pushed
the
select-cluster
branch
from
f896c48 to
c6a2fd7
Compare
|
Thanks @fbricon for your review. |
Fixes jlandersen#62 Signed-off-by: azerr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve selection of cluster
Fixes #62
Signed-off-by: azerr [email protected]