-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select in the explorer treeview the topic, cluster which is created #72
Conversation
I need to clean my code again but it starts working, see the following demo: As you can see in the demo, there are a lot of topics, and the select helps to select quickly the created topic. In other words, this PR gives the capability to select the created topic, or cluster in the treeview. To do that I created the treeview with vscode.createTreeview to benefit with reveal method. (see https://code.visualstudio.com/api/extension-guides/tree-view#registering-the-treedataprovider). The reveal method requires to implement the getParent in the tree data provider, it's the reason why I did a big refactoring to have a KafkaModel. It follows the same idea than NPM view from vscode https://github.com/microsoft/vscode/blob/445f259e34c789125d5cbe0141babdb60704f611/extensions/npm/src/npmView.ts#L218 |
0eac7ab
to
50def4b
Compare
bb42150
to
6443f47
Compare
should be fixed now |
fixed |
6443f47
to
8d64a91
Compare
Fixes jlandersen#61 Signed-off-by: azerr <[email protected]>
Thanks @angelozerr! |
Select in the explorer treeview the topic, cluster which is created
Fixes #61
Signed-off-by: azerr [email protected]