-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide back button navigation in new cluster wizard #60
Conversation
e3832f2
to
d13e696
Compare
This PR improves the two wizards:
with:
for add topic, if you execute add topic from command palette it provides list of cluster to pick it at first. Here a demo with cluster wizard: Here a demo with topic wizard: I need to improve this PR:
|
@jlandersen my PR fails on windows only when tests are executed, I don't understand why although I have not written some tests Have you some idea? |
ad935ae
to
5d9dd84
Compare
Use simple messages like "X is required" Check for blank values: "X can not be blank" |
5d9dd84
to
f2a3fa4
Compare
Done, I updated my PR and now we have a validators.ts which provides commons validator for required filed, positive number etc which follows the same pattern message. |
f2a3fa4
to
3c8ef1e
Compare
3c8ef1e
to
6000b30
Compare
6000b30
to
bade245
Compare
bade245
to
7aacf63
Compare
7aacf63
to
4d7ca6f
Compare
4d7ca6f
to
022acae
Compare
Fixes jlandersen#21 Signed-off-by: azerr <[email protected]>
Thanks @angelozerr. This makes the wizard workflows much better. Now on to #64 and #65 to improve validation |
Provide back button navigation in new cluster wizard
Fixes #21
Signed-off-by: azerr [email protected]