-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completion for available topic in kafka file #158
Conversation
It starts working but I need to clean my code and write tests. When completion is applied for topic (property name or value) it connect to the cluster to get the topics (just the first time). I wonder if this connection must be done only with kafka explorer? |
6ed56ee
to
b8c42c0
Compare
The topics completion is working only if you try to open completion after I did this choice because when cluster is not available it breaks the full property names completion support (because the topics values for choice cannot be done). Is it possible to see this topics value as choice in an another issue? |
ac2643c
to
96fb02b
Compare
1edcefc
to
0770f76
Compare
0770f76
to
694eb66
Compare
Can you add en entry to the changelog? |
694eb66
to
eb8af65
Compare
done |
Fixes jlandersen#150 Signed-off-by: azerr <[email protected]>
eb8af65
to
12c9e76
Compare
Thanks @angelozerr! |
Completion for available topic in kafka file
Fixes #150
Signed-off-by: azerr [email protected]