Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion for available topic in kafka file #158

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

angelozerr
Copy link
Collaborator

Completion for available topic in kafka file

Fixes #150

Signed-off-by: azerr [email protected]

@angelozerr
Copy link
Collaborator Author

It starts working but I need to clean my code and write tests.

When completion is applied for topic (property name or value) it connect to the cluster to get the topics (just the first time). I wonder if this connection must be done only with kafka explorer?

@angelozerr angelozerr force-pushed the completion-topic branch 3 times, most recently from 6ed56ee to b8c42c0 Compare April 10, 2021 09:25
@angelozerr
Copy link
Collaborator Author

The topics completion is working only if you try to open completion after topic: but it doesn't work if you try to open topic: completion item and apply it (topics as choice).

I did this choice because when cluster is not available it breaks the full property names completion support (because the topics values for choice cannot be done). Is it possible to see this topics value as choice in an another issue?

@angelozerr angelozerr force-pushed the completion-topic branch 3 times, most recently from ac2643c to 96fb02b Compare April 10, 2021 20:20
@angelozerr angelozerr marked this pull request as ready for review April 10, 2021 20:20
@angelozerr angelozerr requested a review from fbricon April 10, 2021 20:20
@angelozerr angelozerr force-pushed the completion-topic branch 2 times, most recently from 1edcefc to 0770f76 Compare April 12, 2021 08:47
src/kafka-file/kafkaFileClient.ts Outdated Show resolved Hide resolved
@fbricon
Copy link
Collaborator

fbricon commented Apr 12, 2021

Can you add en entry to the changelog?

@angelozerr
Copy link
Collaborator Author

Can you add en entry to the changelog?

done

CHANGELOG.md Outdated Show resolved Hide resolved
@fbricon fbricon merged commit 1f1fbd4 into jlandersen:master Apr 12, 2021
@fbricon
Copy link
Collaborator

fbricon commented Apr 12, 2021

Thanks @angelozerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion for available topic in kafka file
2 participants