Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion support for kafka file #148

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

angelozerr
Copy link
Collaborator

Completion support for kafka file

Fixes #146

Signed-off-by: azerr [email protected]

@angelozerr
Copy link
Collaborator Author

Completion for static properties names and values should work. Test exists but I need to update doc and clean my code.

@angelozerr angelozerr requested a review from fbricon April 6, 2021 08:00
@fbricon
Copy link
Collaborator

fbricon commented Apr 6, 2021

I get no completion on CONSUMER / PRODUCER

@fbricon
Copy link
Collaborator

fbricon commented Apr 6, 2021

after completing something, you're still in placeholder mode, you don't get the next completion unless you press esc or tab
Apr-06-2021 11-08-35

description: string;
enum?: ModelDefinition[];
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be preferable if the documentation linked to the embedded doc instead

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, but it seems that it's not supported.

@angelozerr
Copy link
Collaborator Author

I get no completion on CONSUMER / PRODUCER

Could you please give me more information about this problem?

@fbricon
Copy link
Collaborator

fbricon commented Apr 6, 2021

Is there a way for the static snippets to not be available when editing in the middle of a block? i.e avoid:
Screenshot 2021-04-06 at 14 07 05

@angelozerr
Copy link
Collaborator Author

angelozerr commented Apr 6, 2021

after completing something, you're still in. placeholder mode, you don't get the next completion unless you press esc or tab

It's the snippet vscode behavior. I fear that there is no fix for that.

@fbricon
Copy link
Collaborator

fbricon commented Apr 6, 2021

if you type PR or CO, you don't get completion for just the keyword PRODUCER or CONSUMER

@angelozerr
Copy link
Collaborator Author

Is there a way for the static snippets to not be available when editing in the middle of a block? i.e avoid:

The only solution is to move those snippet in the language service. I don't know if it's easy to do that. Please create a new issue about that.

@angelozerr
Copy link
Collaborator Author

if you type PR or CO, you don't get completion for just the keyword PRODUCER or CONSUMER

You speak about snippet completion (managed by vscode)?

@fbricon
Copy link
Collaborator

fbricon commented Apr 6, 2021

please update the changelog

@angelozerr angelozerr force-pushed the kafkafile-completion branch from e192dfa to c68a35f Compare April 6, 2021 16:08
@angelozerr
Copy link
Collaborator Author

please update the changelog

fixed

@angelozerr angelozerr force-pushed the kafkafile-completion branch from c68a35f to 75e9c82 Compare April 6, 2021 16:23
@angelozerr angelozerr marked this pull request as ready for review April 6, 2021 16:24
@fbricon fbricon merged commit 4ecdc6f into jlandersen:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion support for properties kafka file
2 participants