Execute Produce code lens in kafka file with progress #141

angelozerr · 2021-03-24T15:35:47Z

Execute Produce code lens in kafka file with progress

Fixes #117

angelozerr · 2021-03-24T15:40:10Z

This PR provides the ProducerCollection concept to be consistent with existing ConsumerCollection. The main idea is to store a wrapper of producer in a collection with a given uri (like consumer does). The uri of producer (identifier) use clusterId, key and value.

I set this PR as draft because I need to clean my code but here a little demo where you can see Producing... code lens:

src/client/client.ts

fbricon · 2021-03-25T16:56:11Z

apart from the missing entry in the changelog, everything LGTM

angelozerr · 2021-03-25T20:37:36Z

apart from the missing entry in the changelog, everything LGTM
added

Please note that I updat emy code to refresh code lensonly for connecting and disconnecting states.

CHANGELOG.md

src/kafka-file/codeLensProvider.ts

src/client/producer.ts

fbricon · 2021-03-26T10:33:04Z

src/commands/producers.ts

+                                channel.appendLine(`Error: ${error.message}`);
+                            } else {
+                                channel.appendLine(`Error: ${error}`);
+                            }


should prolly disconnect the producer in case of an error

Disconnect producer is a bad idea because producer connect takes some times. In otherwise you connect one time to the producer and you disconnect never.

src/kafka-file/codeLensProvider.ts

src/commands/producers.ts

src/client/producer.ts

Fixes jlandersen#117 Signed-off-by: azerr <[email protected]>

fbricon · 2021-03-29T13:28:10Z

Thanks @angelozerr!

fbricon reviewed Mar 25, 2021

View reviewed changes

src/client/client.ts Outdated Show resolved Hide resolved

angelozerr force-pushed the producer-withProgress branch 7 times, most recently from b14f13e to 2fa0a02 Compare March 25, 2021 16:43

angelozerr force-pushed the producer-withProgress branch from 2fa0a02 to ce4354c Compare March 25, 2021 20:36