Only show replication factor input when relevant #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
force-pushed
the
replication-factor
branch
from
7ab0f02 to
0a199c2
Compare
fbricon
commented
Mar 16, 2021
fbricon
force-pushed
the
replication-factor
branch
from
0a199c2 to
f6efaac
Compare
angelozerr
reviewed
Mar 17, 2021
fbricon
force-pushed
the
replication-factor
branch
2 times, most recently
from
deb03e8 to
eeaede1
Compare
When creating a new topic from the wizard: - read offsets.topic.replication.factor from broker config to determine default replication factor - fallback to default.replication.factor - fallback to the lowest value between 3 and the number of brokers (looking at you cloudkarafka) The max number of replicas is determined by the number of brokers. If value <= 1, the replication factor input is not shown in the topic wizard If value > max replicas, a validation error is displayed Signed-off-by: Fred Bricon <[email protected]>
fbricon
force-pushed
the
replication-factor
branch
from
eeaede1 to
e99a28d
Compare
|
Thanks @fbricon ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new topic from the wizard
The max number of replicas is determined by the number of brokers.
If value <= 1, the replication factor input is not shown in the topic wizard
If value > max replicas, a validation error is displayed
Fixes #64