Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors don't surface when starting a consumer fails to authenticate #116

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

angelozerr
Copy link
Collaborator

Errors don't surface when starting a consumer fails to authenticate

Fixes #104

Signed-off-by: azerr [email protected]

@angelozerr
Copy link
Collaborator Author

This PR improves the start / stop consumer:

  • by managing state launch (starting, started, stopping, stopped) which is used by code lens (ex : when a consumer is starting,the start and stop lenses are not displayed)
  • by executing start / stop consumer with progress. It's very helpful when you start a consumer in a cluster which cannot be accessed (you see on the bottom of vscode the progress state)
    image
  • display error when start consumer cannot be executed (ex : cluster cannot be accessed)
  • improve consumer view to display consumer options when it is started + display error

image

@fbricon fbricon merged commit b7d41e4 into jlandersen:master Mar 1, 2021
@fbricon
Copy link
Collaborator

fbricon commented Mar 1, 2021

Thanks @angelozerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors don't surface when starting a consumer fails to authenticate
2 participants