Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve selection of cluster #82

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

angelozerr
Copy link
Collaborator

Improve selection of cluster

Fixes #62

Signed-off-by: azerr [email protected]

@angelozerr
Copy link
Collaborator Author

My work is not finished, but it starts working:

ExporerSelectionDemo

@angelozerr angelozerr force-pushed the select-cluster branch 3 times, most recently from ba88c1a to 7c9439c Compare January 14, 2021 15:04
@@ -48,6 +48,11 @@ export class Icons {
}
}


export enum GlyphChars {
Check = '\u2713'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angelozerr angelozerr marked this pull request as ready for review January 14, 2021 15:19
@angelozerr
Copy link
Collaborator Author

angelozerr commented Jan 14, 2021

The PR can be reviewed, it shows the selected cluster is the tree and manage too the enable/disable of Select Cluster contextual menu according to if cluster is already selected or not.

ExporerSelectionDemo2

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@fbricon fbricon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a small change in the changelog, the rest LGTM. Feel free to merge once you fixed the changelog

@angelozerr angelozerr merged commit 33bbbbd into jlandersen:master Jan 19, 2021
@angelozerr
Copy link
Collaborator Author

Thanks @fbricon for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve selection of cluster
2 participants