Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad highlighting when declaring json messages with fakerjs placeholders #132

Closed
fbricon opened this issue Mar 17, 2021 · 0 comments · Fixed by #157
Closed

Bad highlighting when declaring json messages with fakerjs placeholders #132

fbricon opened this issue Mar 17, 2021 · 0 comments · Fixed by #157
Assignees
@angelozerr
Labels
bug Something isn't working kafka-file producers
Milestone
0.12.0

Comments

@fbricon
Copy link
Collaborator

fbricon commented Mar 17, 2021 •
edited
Loading

See

PRODUCER json-output
topic: fruit-in
{
    "name": "{{random.word}}",
    "price": {{random.number}}
}

yields some weird bracket highlighting :

Screenshot 2021-03-17 at 11 15 17
@fbricon fbricon added bug Something isn't working producers kafka-file labels Mar 17, 2021
@angelozerr angelozerr self-assigned this Apr 8, 2021
@angelozerr angelozerr added this to the 0.12.0 milestone Apr 8, 2021
angelozerr added a commit to angelozerr/vscode-kafka that referenced this issue Apr 8, 2021
@angelozerr
Bad highlighting when declaring json messages with fakerjs placeholders
b1e5b4d 
Fixes jlandersen#132

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr mentioned this issue Apr 8, 2021
Merged
fbricon pushed a commit that referenced this issue Apr 8, 2021
@angelozerr @fbricon
Bad highlighting when declaring json messages with fakerjs placeholders
88675d8 
Fixes #132

Signed-off-by: azerr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working kafka-file producers
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

Bad highlighting when declaring json messages with fakerjs placeholders angelozerr/vscode-kafka
2 participants
@fbricon @angelozerr