Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task 13 - User signup page #13

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Task 13 - User signup page #13

merged 6 commits into from
Oct 16, 2024

Conversation

YamiHeike
Copy link
Collaborator

@YamiHeike YamiHeike commented Oct 14, 2024 •
edited
Loading

Dodałam:

  • Szablon rejestracji konta z placeholderem na logo
  • Controller do tego widoku
  • Hyperlink z łączący index z signup
  • Dodałam placeholder na navbar z logo
  • Zmieniłam design w indeksie żeby był spójny z signup panem

@Slawek84PL Slawek84PL changed the title added signup template Task 14 - User signup page Oct 15, 2024
@Slawek84PL Slawek84PL changed the title Task 14 - User signup page Task 13 - User signup page Oct 15, 2024
Slawek84PL
Slawek84PL reviewed Oct 15, 2024
View reviewed changes
src/main/java/pl/ateam/disasteralerts/web/SignupViewController.java Outdated
@RequestMapping("/signup")
public class SignupViewController {
@GetMapping
public String signup() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public String signup() {
public String signupView() {

tak jak przy indeksie nazwałaś metodę indexView()

@YamiHeike YamiHeike marked this pull request as ready for review October 16, 2024 17:50
@YamiHeike YamiHeike merged commit 1cd7108 into master Oct 16, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkuznik jkuznik jkuznik approved these changes

@Slawek84PL Slawek84PL Slawek84PL approved these changes

@RobertoJavaDev RobertoJavaDev Awaiting requested review from RobertoJavaDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YamiHeike @Slawek84PL @jkuznik