Additional metrics and bug fixes #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new prometheus metric to track how many keys are being requested for MGET operations. This can be useful to understand how much pressure may be put against the Redis proxy when running in Enterprise Clustering, or how much pressure will be put on the nodes when not running in OSS clustering policy. Fixes a bug where Prometheus cache hits metric was being incremented when there was a cache miss. Moves the version to 1.5.1 Signed-off-by: Joseph Kratz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new prometheus metric to track how many keys are being requested for MGET operations. This can be useful to understand how much pressure may be put against the Redis proxy when running in Enterprise Clustering, or how much pressure will be put on the nodes when not running in OSS clustering policy.
Fixes a bug where Prometheus cache hits metric was being incremented when there was a cache miss.
Moves the version to 1.5.1