Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified composer json for support symfony 4.2 #31

Closed
wants to merge 1 commit into from

Conversation

CedrickOka
Copy link

This pull request should be able to use the project with Symfony 4.2

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 99.692% when pulling 16f3d06 on CedrickOka:master into 21058a9 on jkphl:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 99.692% when pulling 16f3d06 on CedrickOka:master into 21058a9 on jkphl:master.

@CedrickOka
Copy link
Author

CedrickOka commented Dec 15, 2018

Hi @jkphl
I would like to use this library in my project symfony 4 is what you can annalyser my pull request that should allow me to do it.

@jkphl jkphl closed this in f33c78d Dec 25, 2018
@jkphl
Copy link
Owner

jkphl commented Dec 25, 2018

@CedrickOka Thanks for your suggestion — this should be done now as of release 3.0.0.

On another note: While I appreciate your contribution, please try to not push by "reminding" me that there's an open PR as this doesn't help at all with my overall workload. In this concrete situation: Allowing Symfony 4.2 required bumping the PHP version constraint, which in turn had a lot of impact on other dependencies as well, so it was far more involved than to just modify the composer.json ...

@CedrickOka
Copy link
Author

@jkphl Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants