-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to build: missing sw-toolbox.js.map #42
Comments
I am unable to reproduce this in a brand new Ember app created with |
I am now able to reproduce with the aforementioned brand new Ember app, by enabling sourcemaps in
Repro app: Simply run |
@bourquep out of curiousity, why do you need sourcemaps in prod? |
We're sending uncaught errors to Airbrake, and I had enabled sourcemaps to enable meaningful backtraces in the Airbrake error reports. Maybe there's another way, I'll investigate. |
For now I've disabled sourcemaps in prod builds so I can deploy my new app version with service worker. |
I see... Not sure why the problem happens, it will require some digging into. I'm thinking the bit of code that includes the already generated sourcemap for sw-toolbox needs to take into account that build setting. |
@bourquep I found the problem. I'll push a build tomorrow with the fix. |
@bourquep new version now available: https://www.npmjs.com/package/broccoli-serviceworker |
Awesome, thanks for the quick fix & deploy! I'll revert my |
@jkleinsc can we add a different config option, other than debug, to define if the map should exist? |
I am unable to build my ember app with
ember build --environment production
since integratingbroccoli-serviceworker
. I get this error:Environment:
The text was updated successfully, but these errors were encountered: