User.delete() doesn't correct call the Intercom API. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intercom._call was not expecting the DELETE method when constructing request data parameters. Hence, the params were being skipped over and the request didn't correctly register with Intercom's API. Added in intergration test to check this is working as indetented. Before, The user returned would be the '[email protected]' not the email specificed ('[email protected]' in the tests case). Now, The user info returned corresponds to the email specified ('[email protected]') as we would expect, as Intercom API 'Returns the deleted user on success' (as according to their docs).
|
Ah yes! Good spot. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Noticed in issue where calling User.delete() was not having the expected behavior (e.g. removing the user from Intercom!).
Tracked it down the the following cause (I've tried my best to explain it, let me know if any of the points require further clarification!).
Intercom._call was not expecting the DELETE method when constructing request data parameters. (line 93 in intercom/intercom.py)
Hence, the params were being skipped over and the request didn't correctly register with Intercom's API.
Added in integration test to check this is working as intended..
Before, the user returned would be the '[email protected]' not the email specified ('[email protected]' in the tests case).
Now, the user info returned corresponds to the email specified ('[email protected]') as we would expect, as Intercom API 'Returns the deleted user on success' (as according to their docs).