Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User.delete() doesn't correct call the Intercom API. #19

Merged
merged 1 commit into from
Nov 18, 2013
Merged

User.delete() doesn't correct call the Intercom API. #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion intercom/intercom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def _call(cls, method, url, params=None):
'User-Agent': 'python-intercom/' + __version__,
'Accept': 'application/json'
}
if method in ('POST', 'PUT'):
if method in ('POST', 'PUT', 'DELETE'):
headers['content-type'] = 'application/json'
req_params['data'] = json.dumps(params)
elif method == 'GET':
Expand Down
4 changes: 4 additions & 0 deletions tests/integration/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ def test_user(self):
user = User.find(email='[email protected]')
self.assertEqual('Somebody', user.name)

def test_delete_user(self):
user = User.delete(email="[email protected]")
self.assertEqual("[email protected]", user.email)

@raises(ResourceNotFound)
def test_not_found(self):
User.find(email='[email protected]')
Expand Down