Skip to content

Commit

Permalink
Relax check on legacy.cpp on all compilers
Browse files Browse the repository at this point in the history
Signed-off-by: Julien Jerphanion <[email protected]>
  • Loading branch information
jjerphan committed Nov 27, 2024
1 parent f991d41 commit 593d1e8
Showing 1 changed file with 5 additions and 8 deletions.
13 changes: 5 additions & 8 deletions libmambapy/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,11 @@ pybind11_add_module(
src/libmambapy/bindings/solver.cpp
src/libmambapy/bindings/solver_libsolv.cpp
)
# TODO: remove when `SubdirData::cache_path()` is removed
if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" OR CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
# This file uses capturing structured bindings, which was fixed in C++20
set_source_files_properties(
src/libmambapy/bindings/legacy.cpp
PROPERTIES COMPILE_FLAGS -Wno-error=deprecated-declarations
)
endif()
# TODO: remove when `SubdirData::cache_path()` is removed This file uses capturing structured
# bindings, which was fixed in C++20
set_source_files_properties(
src/libmambapy/bindings/legacy.cpp PROPERTIES COMPILE_FLAGS -Wno-error=deprecated-declarations
)

target_include_directories(bindings PRIVATE src/libmambapy/bindings)

Expand Down

0 comments on commit 593d1e8

Please sign in to comment.