Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support git credential helpers #773

Merged

Conversation

rslabbert
Copy link
Contributor

Confirmed working due to the existence of this commit which I pushed using the Github CLI credential helper.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)

@martinvonz
Copy link
Member

Thanks! Does this mean that #469 and/or #63 are fixed?

@rslabbert
Copy link
Contributor Author

Based on my read of them, part of #469 is now supported, but jj doesn't integrate with git's credential store as of yet, so not the whole idea.

I don't believe this addresses #63 but it does potentially obviate the need to use SSH for anyone who can take advantage of git credential helpers like Github users.

@martinvonz
Copy link
Member

Okay, thanks for the update. I've never used git credential helpers and I don't really know what they do.

@martinvonz martinvonz merged commit 68b77d1 into jj-vcs:main Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants