Prompt for credentials when needed #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
force-pushed
the
push-6e530c6d8d5d45c2ba31769267ded2db
branch
2 times, most recently
from
3409cb6 to
3ba6597
Compare
Ralith
force-pushed
the
push-6e530c6d8d5d45c2ba31769267ded2db
branch
3 times, most recently
from
6e44e10 to
7826738
Compare
martinvonz
reviewed
Nov 6, 2022
Ralith
force-pushed
the
push-6e530c6d8d5d45c2ba31769267ded2db
branch
4 times, most recently
from
fdbbbf9 to
4f7b296
Compare
martinvonz
reviewed
Nov 7, 2022
martinvonz
approved these changes
Nov 7, 2022
|
Thanks! |
Ralith
force-pushed
the
push-6e530c6d8d5d45c2ba31769267ded2db
branch
2 times, most recently
from
d2121d3 to
62b9387
Compare
Ralith
force-pushed
the
push-6e530c6d8d5d45c2ba31769267ded2db
branch
from
62b9387 to
fc01b9b
Compare
Ralith
force-pushed
the
push-6e530c6d8d5d45c2ba31769267ded2db
branch
2 times, most recently
from
fcbacdc to
1e2db76
Compare
Ralith
force-pushed
the
push-6e530c6d8d5d45c2ba31769267ded2db
branch
from
1e2db76 to
a31aa1c
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terminal password prompts don't go through
Uibecause that underminesrpassword's facility for suppressing terminal echo. Not sure it's worth hacking around that, since the terminal's a global resource anyway.In the long run I'd like to move away from basically aping libgit2 in favor of a more composable async API, but that's major refactoring that shouldn't block basic UI cleanup.
I couldn't come up with a graceful way to prompt for usernames via pinentry, so it's relegated to the password-only case.
Checklist
If applicable:
CHANGELOG.md