tests: keep user's $PATH while running jj commands
#5468
Merged
+79
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
martinvonz
reviewed
Jan 26, 2025
scott2000
force-pushed
the
push-msplqmqzksqv
branch
3 times, most recently
from
19d357b to
9542318
Compare
|
This looks great! Thank you for doing this, getting a hang of it was very annoying to begin with and this is much cleaner! I think we should definitely do the |
martinvonz
reviewed
Jan 26, 2025
scott2000
force-pushed
the
push-msplqmqzksqv
branch
from
9542318 to
8662d49
Compare
Currently, the Git subprocess tests only work on Linux due to a default path being used for the `git` executable when `$PATH` is unset. This can break if Git isn't installed at the expected path. Also, I believe it is currently necessary to set the `$TEST_GIT_EXECUTABLE_PATH` environment variable on Windows for tests to pass. Instead, we should use the user's `$PATH` to locate the `git` executable, as well as any other executables that are needed. This also makes `$TEST_GIT_EXECUTABLE_PATH` no longer necessary, so it can be removed.
scott2000
force-pushed
the
push-msplqmqzksqv
branch
from
8662d49 to
766adcd
Compare
martinvonz
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Git subprocess tests only work on Linux due to a default path being used for the
gitexecutable when$PATHis unset. This can break if Git isn't installed at the expected path. Also, I believe it is currently necessary to set the$TEST_GIT_EXECUTABLE_PATHenvironment variable on Windows for tests to pass. Instead, we should use the user's$PATHto locate thegitexecutable, as well as any other executables that are needed. This also makes$TEST_GIT_EXECUTABLE_PATHno longer necessary, so it can be removed.Discussed in #5463.
Checklist
If applicable:
CHANGELOG.md