Use FILESETS/REVSETS for placeholders in command synopsis
#5133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvonz
force-pushed
the
push-nqummxmyuvtl
branch
from
7f2ab4c to
b32c0dd
Compare
|
Should we also change the accompanying doc comments then, e.g. path(s) / file(s) → fileset(s), revision(s) → revset(s)? |
fowles
approved these changes
Dec 18, 2024
yuja
approved these changes
Dec 18, 2024
This should help clarify that the arguments are not just simple paths (assuming `ui.allow-filesets` is not disabled).
This should help clarify that the arguments are not just simple change ids or commit ids.
martinvonz
force-pushed
the
push-nqummxmyuvtl
branch
from
b32c0dd to
1f8c4bb
Compare
Yes, we should probably basically replace all "paths" by "paths matching these filesets" and "revisions" by "revisions matching these revsets". I'll try to remember to do that in a followup. I think this PR is an improvement on its own, and I should get back to the copy-tracking design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @fowles and @yuja for the inspiration.
Checklist
If applicable:
CHANGELOG.md