Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: skip test_shallow_commits_lack_parents under Nix builds #4839

Closed
wants to merge 2 commits into from
Closed

nix: skip test_shallow_commits_lack_parents under Nix builds #4839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e537c6a
nix: flake update
thoughtpolice Nov 12, 2024
c393825
nix: skip `test_shallow_commits_lack_parents` test under Nix
thoughtpolice Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions flake.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,14 @@
buildFeatures = [ "packaging" ];
cargoBuildFlags = [ "--bin" "jj" ]; # don't build and install the fake editors
useNextest = true;

checkFlags = [
# https://github.com/martinvonz/jj/issues/4784
# seems to fail reliably under Nix/nix-shell only, but otherwise
# is an unknown anomaly?
"--skip" "test_shallow_commits_lack_parents"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nextest native syntax would involve --filterset, and AIUI you need a -- for --skip – does this actually work to skip it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware of the filterset expression, but I chose this in part because I think --skip reads much more naturally (part of the reason it was presumably added back to nextest, along with the fact it's backwards compatible with older versions; when I originally tried diagnosing this I had to spend 5 minutes figuring out why --skip was reworked and the right way to skip tests, which involved a nice bug report.) Regarding the -- yes, it's because the actual Nix harness around cargo test adds it for you. I've never seen --skip used in any other way in any Rust+Nix project FWIW, so I've assumed this was always the default behavior.

];

src = filterSrc ./. [
".*\\.nix$"
"^.jj/"
Expand Down