cli: Refactor a reusable git_fetch function from the command.
#4767
+106
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essiene
force-pushed
the
essiene/vutlmutyytky
branch
3 times, most recently
from
3a16b88 to
d6df47f
Compare
essiene
changed the title
git_fetch function from the command.git_fetch function from the command.
essiene
force-pushed
the
essiene/vutlmutyytky
branch
from
d6df47f to
4a4ac40
Compare
yuja
approved these changes
Nov 5, 2024
essiene
force-pushed
the
essiene/vutlmutyytky
branch
from
4a4ac40 to
f4b6e5b
Compare
We will need this in the `jj git sync` command to perform a fetch that behaves the same as the `jj git fetch` command. * Refactor out `git_fetch` and move it to `git_util.rs` * Also move `warn_if_branches_not_found`. It is only used by `git_fetch` * Move `map_git_error` to `git_util.rs` and update other call sites to import correctly. * Update using statements as needed. All tests still pass as this is a noop. Part of: #1039
essiene
force-pushed
the
essiene/vutlmutyytky
branch
from
f4b6e5b to
1b5a5c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will need this in the
jj git synccommand to perform a fetch that behavesthe same as the
jj git fetchcommand.git_fetchand move it togit_util.rswarn_if_branches_not_found. It is only used bygit_fetchmap_git_errortogit_util.rsand update other call sites to import correctly.All tests still pass as this is a noop.
Part of: #1039