Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changelog: conflict() and file() deprecations are yet unreleased. #4532

Merged
merged 1 commit into from
Sep 25, 2024
Merged

changelog: conflict() and file() deprecations are yet unreleased. #4532

merged 1 commit into from
Sep 25, 2024

Conversation

essiene
Copy link
Collaborator

@essiene essiene commented Sep 25, 2024 •
edited
Loading

Move this update under Unreleased. I started the change before the last release and after rebasing, forgot to move it. Fixing it now thanks to @yuja catching this on time.

Issue: #4122

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@essiene essiene enabled auto-merge (rebase) September 25, 2024 07:59
@essiene essiene requested a review from yuja September 25, 2024 07:59
@essiene essiene mentioned this pull request Sep 25, 2024
Merged
4 tasks
martinvonz
martinvonz reviewed Sep 25, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
yuja
yuja approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

CHANGELOG.md Show resolved Hide resolved
@essiene essiene disabled auto-merge September 25, 2024 08:25
@essiene essiene force-pushed the essiene/pktnoyvrrkpo branch from 04242ef to f9cbefa Compare September 25, 2024 08:28
@essiene
changelog: conflict() and file() deprecations are yet unreleased.
e93e44a 
Move this update under `Unreleased`. I started the change before the last
release and after rebasing, forgot to move it. Fixing it now thanks to @yuja
catching this on time.

Issue: #4122
@essiene essiene force-pushed the essiene/pktnoyvrrkpo branch from f9cbefa to e93e44a Compare September 25, 2024 08:31
@essiene essiene merged commit e99cca8 into main Sep 25, 2024
31 checks passed
@essiene essiene deleted the essiene/pktnoyvrrkpo branch September 25, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonz martinvonz martinvonz approved these changes

@yuja yuja yuja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@essiene @yuja @martinvonz