templates: add .normal_hex() for {Commit,Change}Id #4477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuja
reviewed
Sep 16, 2024
avamsi
force-pushed
the
jj_wokvqlnoyppv
branch
2 times, most recently
from
5740549 to
4f3e860
Compare
avamsi
changed the title
avamsi
force-pushed
the
jj_wokvqlnoyppv
branch
from
4f3e860 to
2ef91ca
Compare
avamsi
changed the title
|
@yuja are you good with this now? (Or if anyone else has any opinions..) |
This doesn't do much for CommitId but outputs the "forward" hex for ChangeId, which can be useful to use as Gerrit Change-Id.
avamsi
force-pushed
the
jj_wokvqlnoyppv
branch
from
2ef91ca to
88a0e77
Compare
|
For posterity, I'm using it like this -- [templates]
draft_commit_description = '''
separate("\n",
description.remove_suffix("\n"),
if(description.contains(change_id.normal_hex()),
"",
"\nChange-Id: Id0000000" ++ change_id.normal_hex()
),
"\n",
surround("JJ: Changes:\n", "", indent("JJ: \t", diff.summary()))
)
''' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't do much for CommitId but outputs the "forward" hex for
ChangeId, which can be useful to use as Gerrit Change-Id.
Checklist
If applicable:
CHANGELOG.md