Be more specific when warning the user about missing identity configs #4429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
force-pushed
the
push-ytkyrovrspwk
branch
from
b01a485 to
432938c
Compare
|
Any thoughts on this? Feels like a very simple QoL change |
Veykril
force-pushed
the
push-ytkyrovrspwk
branch
from
432938c to
5182401
Compare
Check if only the email or the name are missing in the config and specifically name the missing one, instead of always defaulting to potentially both missing.
Veykril
force-pushed
the
push-ytkyrovrspwk
branch
from
5182401 to
3e69cfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typoed
user.nameasuser.naneand got confused why my entire user didn't get recognized, warning on each command.Checklist
If applicable:
CHANGELOG.md