Color signature names yellow within the log #4335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
yuja
reviewed
Aug 25, 2024
qubitz
force-pushed
the
make-names-yellow
branch
2 times, most recently
from
374e497 to
c657a2a
Compare
|
Good call @yuja with the suggestion. Looks more consistent:
PR is ready for merging. Let me know what I can do to get the CI passing. |
yuja
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Thanks.
You'll need to update test snapshots by cargo insta test && cargo insta review.
https://martinvonz.github.io/jj/latest/contributing/#summary
qubitz
force-pushed
the
make-names-yellow
branch
3 times, most recently
from
69bf38f to
a5ecdfa
Compare
qubitz
force-pushed
the
make-names-yellow
branch
from
a5ecdfa to
3e18d93
Compare
When `format_short_signature(signature)` is set to `signature.name()` the author names are not yellow like other signature types (eg email and username). When the commit signatures have no colors, they blend in making it hard to distinguish between signatures and commit messages. If just `name` were set to `yellow`, just like email and username, it affects the colorization of branch names making them also yellow despite them being designated as magenta. Setting `author` and `committer` to `yellow` is specific enough to allow branches to keep their colors while still coloring signature names. This is known to affect signatures in both 'log' and 'show'.
qubitz
force-pushed
the
make-names-yellow
branch
from
3e18d93 to
bbb8e3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included the details in the commit message. There is probably a better way to do this, but I've been running with these changes in my local config.toml and seem to be working well with no other color conflicts. Suggestions welcome.
Checklist
If applicable:
CHANGELOG.md