copies: determine copy/rename operation by CopiesTreeDiffStream #4316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fowles
approved these changes
Aug 22, 2024
I'm going to add some methods, and I don't want to insert them in between the stream type and impls.
It seems a slightly better, and aligns with the local variable name in materialized_diff_stream().
This patch adds accessor methods as I'm going to change the underlying data types. Since entry values are consumed separately, these methods are implemented on CopiesTreeDiffEntryPath, not on *TreeDiffEntry.
Most diff entries should have no copy sources.
Not all callers need this information, but I assumed it's relatively cheap to look up the source path in the target tree compared to diffing. This could be represented as Regular(_)|Copied(_, _)|Renamed(_, _), but it's a bit weird if Copied and Renamed were separate variants. Instead, I decided to wrap copy metadata in Option.
yuja
force-pushed
the
push-qpqzrnsprxmr
branch
from
88ce7b0 to
d83dc93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md