Add a reversed flag to jj op log #4301
Conversation
| |OperationByEndTime(op)| op.parents().map_ok(OperationByEndTime).collect_vec(), | ||
| ) | ||
| } else { | ||
| dag_walk::topo_order_reverse_ok( |
There was a problem hiding this comment.
Dropping lazy version is undesired. Maybe better to handle --reversed by caller in the same way as cmd_log(). I think the ancestors iterator can be mapped to (OperationId, Vec<GraphEdge<OperationId>>) or (Operation, Vec<GraphEdge<Operation>>) which is compatible with ReverseGraphIterator.
It might make sense to reimplement ReverseGraphIterator to support (T, Vec<GraphEdge<Id>>) pair.
Sure! The code looks similar enough to the |
|
Just a heads up that I've opened #5329 for this. |
|
Closed by #5329. |
Checklist
If applicable:
CHANGELOG.mdI have updated the documentation (README.md, docs/, demos/)auto generatedI have updated the config schema (cli/src/config-schema.json)N/AIn order to resolve #4190.