github: build on macos-13 for x86_64 #4243
Conversation
|
Thank you Austin! It looks like the macos-13 runners are not marked as required and ran in 6 minutes. I think we can just merge this? |
But we probably want to mark them as required once this is in, right? |
I'm not sure. Austin was worried that these tests might be slow to get runners, since Intel Mac runners might be (or may become) a scarce resource. If that's the case, it might make sense to keep them optional. For me, the important thing is that the tests run regularly so that we eventually become aware if they stop working. For example, we'll now know when GitHub removes these runners before a release fails to build. |
thoughtpolice
force-pushed
the
aseipp/push-zsqppmzpsnrs
branch
from
2d17a2b to
799aa7d
Compare
thoughtpolice
changed the title
macos-13 (x86)
thoughtpolice
force-pushed
the
aseipp/push-zsqppmzpsnrs
branch
from
799aa7d to
7fccdbe
Compare
|
Let's just go ahead and move forward with adding |
We all noticed that x86 macOS binaries are no longer being provided on release, due to `macos-11` runners going the way of the Dodo a while back. Nobody alterted us to this, funny enough. After some quick discussion, we concluded some things: - x86 macOS runners are likely oversubscribed, and hurt CI latency badly - `macos-12` is also deprecated; `macos-13` is the best x86 runner available - GitHub probably isn't going to expand macOS runner capacity; `macos-13` will one day go away - Some people are still using `jj` on Intel Macs. We didn't get alerted because they do their own builds for now, but may not always do that. - We can just try to build on `macos-13` and make it optional for merges. So that's what this does. It might be mergeable outright, but we can also use it to measure build latency impacts. Signed-off-by: Austin Seipp <[email protected]>
thoughtpolice
force-pushed
the
aseipp/push-zsqppmzpsnrs
branch
from
7fccdbe to
376f39a
Compare
We all noticed that x86 macOS binaries are no longer being provided on release, due to
macos-11runners going the way of the Dodo a while back. Nobody alterted us to this, funny enough.After some quick discussion, we concluded some things:
macos-12is also deprecated;macos-13is the best x86 runner availablemacos-13will one day go awayjjon Intel Macs. We didn't get alerted because they do their own builds for now, but may not always do that.macos-13and make it optional for merges.So that's what this does. It might be mergeable outright, but we can also use it to measure build latency impacts.
Checklist
If applicable:
CHANGELOG.md