Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wintest ci (For CI -- test that the parent PR works) #4183

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Wintest ci (For CI -- test that the parent PR works) #4183

wants to merge 7 commits into from

Conversation

ilyagr
Copy link
Contributor

@ilyagr ilyagr commented Jul 30, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@bnjmnt4n
cargo: bump git2 to 0.19.0
9a6e5d4 
This includes a bump of `libgit2` to v1.8.1.
@ilyagr ilyagr mentioned this pull request Jul 30, 2024
Closed
@ilyagr ilyagr changed the title Wintest ci Wintest ci (For CI -- test that the parent PR works) Jul 30, 2024
@ilyagr
Copy link
Contributor Author

ilyagr commented Jul 30, 2024 •
edited
Loading

This is meant to check that the merge of #4080 and #4184 Update: #4188 works, but the CI doesn't seem to run for some reason when the PR is a real merge. Let me try constructing the merge artificially...

(Update: The merge of #4080 and #4184 does work, but I don't think I'll be updating #4184 much)

@ilyagr ilyagr force-pushed the wintest-ci branch 12 times, most recently from 4bb1cac to 5948ea4 Compare July 31, 2024 04:42
@ilyagr ilyagr force-pushed the wintest-ci branch 3 times, most recently from 71f96c0 to 31c5d3f Compare July 31, 2024 07:03
ilyagr added 3 commits July 31, 2024 00:21
@ilyagr
dunce
1d6dc32
@ilyagr
cli git remote add/set-url: use sanitize_git_url_if_path
bed1ca1 
It seems like an oversight that the algorithm from `jj git clone`
wasn't used in them before
@ilyagr
(For CI -- test that the parent PR works)
c69f104
@ilyagr ilyagr mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilyagr @bnjmnt4n