Warn user about the working copy when configuring the author

[InCogNiTo124]

Closes #4042

Checklist

If applicable:

• I have updated CHANGELOG.md

TODO

• Add jj git init flags for user and email Deprecated
• make jj describe --no-edit accept a revset Deprecated, fixed by describe: allow updating the description of multiple commits #3828

[InCogNiTo124]

Add jj git init flags for user and email

It's not clear to me how I should approach this. I noticed there's a config::ConfigBuilder but I don't think I can easily override UserSettings or RepoSettings. All suggestions welcome (including takeover from someone with more know-how 😃 )

[yuja]

Add jj git init flags for user and email

It's not clear to me how I should approach this.

I personally don't think this is good idea, but if needed, it's probably easier to implement as global flags. (See how --color is translated to config value.)

[InCogNiTo124]

if needed, it's probably easier to implement as global flags

I would argue that that's not a clean solution, either, since those flags are only needed for jj git init

[yuja]

if needed, it's probably easier to implement as global flags

I would argue that that's not a clean solution, either, since those flags are only needed for jj git init

I'm not sure why it's needed for (and should be restricted to) jj git init. User name/email applies globally, so it might make sense to do jj describe --user foo. (To be clear, I don't think the global flag is needed because it can be achieved by --config-toml ...)

[InCogNiTo124]

Tested with following snippets that it works:

Testing snippet

❯ JJ_USER=user1 JJ_EMAIL=email1 jj git init .
Initialized repo in "."
❯ jj log
@  smytynvq email1 2024-08-06 21:11:21 303fc106
│  (empty) (no description set)
◆  zzzzzzzz root() 00000000
❯ jj config set --repo user.email "email2"
Warning: This setting will only impact future commits.
The author of the working copy will stay "user1 <email1>". 
To change it, use "jj describe --reset-author --no-edit"
❯ jj log
@  smytynvq email1 2024-08-06 21:11:21 303fc106
│  (empty) (no description set)
◆  zzzzzzzz root() 00000000
❯ jj describe --reset-author --no-edit
Working copy now at: smytynvq 1f2c39c8 (empty) (no description set)
Parent commit      : zzzzzzzz 00000000 (empty) (no description set)
❯ jj log
@  smytynvq email2 2024-08-06 21:12:08 1f2c39c8
│  (empty) (no description set)
◆  zzzzzzzz root() 00000000
❯ echo 'a' > a; jj commit -m 'a'; jj log
Working copy now at: xywsopol 5973def1 (empty) (no description set)
Parent commit      : smytynvq 92a5caae a
@  xywsopol email2 2024-08-06 21:12:45 5973def1
│  (empty) (no description set)
○  smytynvq email2 2024-08-06 21:12:45 92a5caae
│  a
◆  zzzzzzzz root() 00000000
❯ jj config set --repo user.email "[email protected]"
Warning: This setting will only impact future commits.
The author of the working copy will stay "InCogNiTo124 <email2>". 
To change it, use "jj describe --reset-author --no-edit"
❯ jj describe --no-edit --reset-author 'author("email2")'; jj log
Updated 2 commits
Working copy now at: xywsopol cbae64d7 (empty) (no description set)
Parent commit      : smytynvq c8442055 a
@  xywsopol [email protected] 2024-08-06 21:13:53 cbae64d7
│  (empty) (no description set)
○  smytynvq [email protected] 2024-08-06 21:13:53 c8442055
│  a
◆  zzzzzzzz root() 00000000

[yuja]

Thanks!

[InCogNiTo124]

@yuja I believe this can be merged

[yuja]

@yuja I believe this can be merged

Yes. Maybe you don't have a permission to merge the PR yet?

cc @martinvonz

[martinvonz]

@yuja I believe this can be merged

Yes. Maybe you don't have a permission to merge the PR yet?

Yes, that's correct. Sorry that I didn't realize :(