Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the new graph nodes by default #4095

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Enable the new graph nodes by default #4095

merged 1 commit into from
Jul 16, 2024

Conversation

algmyr
Copy link
Contributor

@algmyr algmyr commented Jul 15, 2024 •
edited
Loading

It's been tested in various places now, so this is probably mature enough to be the default.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@ilyagr ilyagr mentioned this pull request Jul 16, 2024
Closed
@algmyr algmyr marked this pull request as ready for review July 16, 2024 07:33
@algmyr algmyr force-pushed the algmyr/push-wwkzqupzyqly branch 2 times, most recently from aab1828 to c3c4291 Compare July 16, 2024 07:59
yuja
yuja approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cli/tests/test_abandon_command.rs Show resolved Hide resolved
@algmyr
Enable the new graph nodes by default.
9450aba 
It's been tested in various places now, so this is probably mature
enough to be the default.
@algmyr algmyr force-pushed the algmyr/push-wwkzqupzyqly branch from c3c4291 to 9450aba Compare July 16, 2024 10:36
@algmyr algmyr merged commit c7eac90 into main Jul 16, 2024
29 checks passed
@algmyr algmyr deleted the algmyr/push-wwkzqupzyqly branch July 16, 2024 10:54
@thoughtpolice thoughtpolice mentioned this pull request Jul 16, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuja yuja yuja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@algmyr @yuja