Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: replace jj files, jj chmod with jj file list, jj file chmod. #3956

Merged
merged 2 commits into from
Jun 25, 2024
Merged

docs: replace jj files, jj chmod with jj file list, jj file chmod. #3956

merged 2 commits into from
Jun 25, 2024

Conversation

ilyagr
Copy link
Contributor

@ilyagr ilyagr commented Jun 25, 2024

No description provided.

ilyagr added 2 commits June 24, 2024 20:43
@ilyagr
docs: replace jj files -> jj file list
c426ff3 
`jj files` is now deprecated
@ilyagr
docs: replace jj chmod -> jj file chmod
14e4d19 
`jj chmod` is now deprecated
@ilyagr ilyagr marked this pull request as ready for review June 25, 2024 03:43
arxanas
arxanas approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@arxanas arxanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chmod is also a Unix-ism, so we might want to find a more neutral term for the ultimate version.

@ilyagr
Copy link
Contributor Author

ilyagr commented Jun 25, 2024

Thanks!

chmod is also a Unix-ism, so we might want to find a more neutral term for the ultimate version.

It could be jj file mode, I guess. I'd probably still keep chmod as an alias.

@ilyagr ilyagr merged commit 40bb207 into jj-vcs:main Jun 25, 2024
17 checks passed
@ilyagr ilyagr deleted the files branch June 25, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arxanas arxanas arxanas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilyagr @arxanas