Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: remove Option<_> wrapping from ui.hint_() helpers #3900

Merged
merged 5 commits into from
Jun 18, 2024
Merged

ui: remove Option<_> wrapping from ui.hint_() helpers #3900

merged 5 commits into from
Jun 18, 2024

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Jun 17, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

PhilipMetzger
PhilipMetzger approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

yuja added 5 commits June 18, 2024 09:26
@yuja
ui: replace qualified std::io path
aa73316 
The "io" module is imported.
@yuja
formatter: add .labeled().with_heading() helper
6f0a374 
I'm going to add a few callers of .with_heading() outside of ui.rs.
@yuja
cli: inline labeling of trackable remote branches hints
d8516db 
This makes it clear that these hints are printed only if status output is
enabled.
@yuja
cli: don't reuse ui.hint_default() instance to print multiple hints
e3ff195 
ui.hint_*() calls will be inlined by the next commit.
@yuja
ui: remove Option<_> wrapping from ui.hint_() helpers
eb005ac 
It's cumbersome to unwrap the Option just to print a short hint message. Let's
send the message to null output instead.
@yuja yuja force-pushed the push-ltyvywospwpv branch from 126408c to eb005ac Compare June 18, 2024 00:29
@yuja yuja enabled auto-merge (rebase) June 18, 2024 00:29
@yuja yuja merged commit 8e56719 into jj-vcs:main Jun 18, 2024
17 checks passed
@yuja yuja deleted the push-ltyvywospwpv branch June 18, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipMetzger PhilipMetzger PhilipMetzger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuja @PhilipMetzger