Add examples to revset doc #3897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuja
reviewed
Jun 17, 2024
`..` is shorthand for `root()..visible_head()`, for example. We don't seem to explain that anywhere. I hope mentioning that will help readers understand the relationship between the shorthands and the full `x..y`, and also to see the correspondence between `..` and `::` (in how their default left and right operands are the same).
martinvonz
force-pushed
the
push-woyuynyulwyn
branch
2 times, most recently
from
ceea1d8 to
984197b
Compare
yuja
approved these changes
Jun 17, 2024
There's been a lot of questions about the subtle differences between `..` and `::`. I hope these examples will help with that. We should also add examples to the revset functions (e.g. `heads()` is not obvious how it works), but that can come later.
martinvonz
force-pushed
the
push-woyuynyulwyn
branch
from
984197b to
bfcd066
Compare
martinvonz
commented
Jun 17, 2024
ilyagr
reviewed
Jun 17, 2024
| * `::x`: Ancestors of `x`, including the commits in `x` itself. | ||
| * `x::`: Descendants of `x`, including the commits in `x` itself. Shorthand for | ||
| `x::visible_heads()`. | ||
| * `x..`: Revisions that are not ancestors of `x`. Shorthand for |
There was a problem hiding this comment.
We could add "Never includes revisions in x", or something to this effect.
ilyagr
reviewed
Jun 17, 2024
|
First of all, thank you, this is really nice! |
ilyagr
reviewed
Jun 17, 2024
| o root() | ||
| ``` | ||
|
|
||
| **Operator** `x-` |
There was a problem hiding this comment.
Perhaps we should turn this into a table?
ilyagr
reviewed
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md