docs CLI Reference: upgrade clap-markdown to 0.1.4 (fixes important bugs)
#3891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyagr
changed the title
clap-markdown (fixes important bugs)clap-markdown to 0.1.4 (fixes important bugs)
ilyagr
force-pushed
the
clap-markdown-new
branch
2 times, most recently
from
35d5c52 to
11b63b7
Compare
ilyagr
changed the title
clap-markdown to 0.1.4 (fixes important bugs)clap-markdown to 0.1.4 (fixes important bugs)
thoughtpolice
approved these changes
Jun 15, 2024
|
There are a few new (and old) imperfections, I might fix them in a separate PR since it involves changing the docstrings:
More, for future reference
|
|
I will wait for a few hours before merging, in case anyone has comments (or wants me to wait longer). |
|
I added a minor fixup (comment deletion) as a separate commit. |
ilyagr
force-pushed
the
clap-markdown-new
branch
from
ca9008a to
0650e4b
Compare
Fixes important bugs. 🎉
I am currently not aware of any severe differences between the generated markdown and `jj help`, though this could change if we look over the text carefully or if we start using `clap` features we weren't using before.
That old commit made a piece of documentation obsolete, but I didn't realize it at the time.
If I can't tell what this comment means, probably nobody else can either. I think it might be a copy-paste error from whatever docs I copied the initial version of the config from.
ilyagr
force-pushed
the
clap-markdown-new
branch
from
0650e4b to
20cc26d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md