Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revset: give descendants() a generation limit arg #3780

Merged
merged 1 commit into from
Jun 14, 2024
Merged

revset: give descendants() a generation limit arg #3780

merged 1 commit into from
Jun 14, 2024
+43 −9

Conversation

BatmanAoD
Copy link
Collaborator

@BatmanAoD BatmanAoD commented May 29, 2024 •
edited
Loading

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • (N/A) I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@BatmanAoD BatmanAoD force-pushed the descendants-range branch from 3fa67b4 to 3c1a7c7 Compare May 29, 2024 04:52
@BatmanAoD BatmanAoD force-pushed the descendants-range branch 2 times, most recently from ad843ee to 0955d25 Compare June 13, 2024 05:52
@BatmanAoD BatmanAoD marked this pull request as ready for review June 13, 2024 05:52
martinvonz
martinvonz reviewed Jun 13, 2024
View reviewed changes
lib/src/revset.rs Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
yuja
yuja reviewed Jun 13, 2024
View reviewed changes
lib/src/revset.rs Show resolved Hide resolved
lib/src/revset.rs Outdated Show resolved Hide resolved
@BatmanAoD BatmanAoD force-pushed the descendants-range branch from 0955d25 to 072a313 Compare June 13, 2024 16:39
@BatmanAoD BatmanAoD changed the title give descendants a range arg revset: give descendants() a generation limit arg Jun 14, 2024
@BatmanAoD BatmanAoD force-pushed the descendants-range branch from 072a313 to 0f9d2f6 Compare June 14, 2024 00:45
@BatmanAoD BatmanAoD force-pushed the descendants-range branch from 0f9d2f6 to af40469 Compare June 14, 2024 00:46
@BatmanAoD BatmanAoD requested review from yuja and martinvonz June 14, 2024 00:46
martinvonz
martinvonz approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BatmanAoD BatmanAoD enabled auto-merge (rebase) June 14, 2024 00:51
@BatmanAoD BatmanAoD merged commit 03a0921 into jj-vcs:main Jun 14, 2024
17 checks passed
@BatmanAoD BatmanAoD deleted the descendants-range branch June 29, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonz martinvonz martinvonz approved these changes

@yuja yuja Awaiting requested review from yuja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BatmanAoD @yuja @martinvonz