Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: adjust jj branch subcommands #353

Merged

Conversation

arxanas
Copy link
Contributor

@arxanas arxanas commented May 28, 2022

Checklist

  • I have made relevant updates to CHANGELOG.md

Closes #330.

Oops, I'd better update the changelog. This PR is otherwise fine for review in the meantime. By the way, where is the documentation for jj git push? I was trying jj push.

@arxanas arxanas force-pushed the push-d000c00e27bc4e86897a3e104e31860f branch from b987926 to caec01d Compare May 28, 2022 08:04
src/commands.rs Show resolved Hide resolved
src/commands.rs Show resolved Hide resolved
src/commands.rs Outdated Show resolved Hide resolved
src/commands.rs Outdated Show resolved Hide resolved
src/commands.rs Show resolved Hide resolved
src/commands.rs Outdated Show resolved Hide resolved
src/commands.rs Outdated Show resolved Hide resolved
@arxanas arxanas force-pushed the push-d000c00e27bc4e86897a3e104e31860f branch 3 times, most recently from efd908b to 06c0275 Compare May 30, 2022 04:33
@martinvonz
Copy link
Member

Thanks! This looks good to me, but can you update the changelog and squash the two commits (or keep them the way they are but make the changes match the descriptions)?

@arxanas arxanas marked this pull request as draft June 3, 2022 18:53
@arxanas arxanas force-pushed the push-d000c00e27bc4e86897a3e104e31860f branch 4 times, most recently from b3f2028 to 08f6ee8 Compare June 6, 2022 00:51
@arxanas arxanas force-pushed the push-d000c00e27bc4e86897a3e104e31860f branch from 08f6ee8 to 1b49fef Compare June 6, 2022 03:23
@arxanas
Copy link
Contributor Author

arxanas commented Jun 6, 2022

  • Updated changelog.
  • Squashed commits. (It was too hard to separate out the changes back into the commits I originally intended 🙄.)

@arxanas arxanas marked this pull request as ready for review June 6, 2022 03:24
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@martinvonz martinvonz merged commit de1c8f0 into jj-vcs:main Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid using same command for querying and mutating (e.g. branches)
2 participants