templater: Add operation.snapshot() boolean and default template hook #3460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
yuja
reviewed
Apr 5, 2024
necauqua
force-pushed
the
necauqua/push-sxxrozrlttzp
branch
from
52b61ce to
0701763
Compare
yuja
approved these changes
Apr 7, 2024
Expose the information we now record, to allow changing the default "snapshot working copy" message or to make snapshots more compact/less distracting in the log
This is to allow modifying default templates without completely overriding them, for example to change the oplog snapshots but keep other defaults
necauqua
force-pushed
the
necauqua/push-sxxrozrlttzp
branch
from
0701763 to
64d9c5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that ideally there will be elided nodes for consecutive snapshots in the log, and the full oplog as it's shown now will require something like an
--allflag.But I looked at how
jj logdoes elision and it went just a bit over my head atm 🙃Also I wrote those hooks to use the implicit
selfsince passing everything as args, especially when there's a possibility more things will be added (likesnapshot) is unwieldy.When I added
builtin_log_root(change_id, commit_id)I just did not realize I could do that 🤷And also those are hooks, not builtins, so the builtin_ name is bad, it's more consistent for them to be one of the format_ functions - see the comment about maybe having some sort of
deprecatedtemplater function that'll make jj emit warnings about hooks being changed?.Checklist
If applicable:
CHANGELOG.md