Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: use a "leftward harpoon over rightward harpoon" for elided nodes #3124

Closed
wants to merge 1 commit into from

Conversation

thoughtpolice
Copy link
Collaborator

@thoughtpolice thoughtpolice commented Feb 22, 2024

This is just an experiment to see how a new elided node looks. I like the feature, but I think the text is a little hard to see due to the lack of surrounding whitespace; having a more distinct marker might help split the difference.

Also, the existing pick, DOTTED CIRCLE, seen as , sometimes renders very poorly in certain fonts, depending on a number of factors. I think a contributing factor is that not all fonts have monospace unicode characters for this block of characters; it also seems as if DOTTED CIRCLE is not in the same "logical group" of characters in that block that includes our lovely , which is FISHEYE. Maybe another ... CIRCLE character would be better, but the ones close by don't seem too great for this purpose.

Instead, this picks a completely distinct character, using LEFTWARD HARPOON OVER RIGHTWARD HARPOON, seen as to mark elided nodes, since it kind of reminded me of a "scissor snip", removing the middle of a string, or something.

To keep a similar visual language, = is used in ASCII.

I've been running this for a week or so, and I quite like it. But I figured I'd put it up here in case anyone else wants to try it. We could also make it configurable, but maybe this could be a better default? I'm not sure. We'd have to get people to try it.

Here is an example from my inline VS Code terminal, using PragmataPro Mono:

image

@NoahTheDuke
Copy link

I like it

@thoughtpolice thoughtpolice force-pushed the aseipp/push-tysptmvuylvu branch 2 times, most recently from 9891cfc to e0d0431 Compare February 27, 2024 17:51
@thoughtpolice thoughtpolice force-pushed the aseipp/push-tysptmvuylvu branch from e0d0431 to 9cdccec Compare March 4, 2024 22:51
@ilyagr
Copy link
Collaborator

ilyagr commented Mar 9, 2024

This makes me think about using ~ if we can't use the dotted circle. The harpoons look a little busy by comparison. I think they are fine, though.

At some point, I guess we can have various themes for the graph :)

@thoughtpolice thoughtpolice force-pushed the aseipp/push-tysptmvuylvu branch from 9cdccec to 8e7b8a9 Compare March 9, 2024 02:49
@thoughtpolice
Copy link
Collaborator Author

This was obsoleted via #3263, so closing. You can use whatever node you want now. :)

@thoughtpolice thoughtpolice deleted the aseipp/push-tysptmvuylvu branch March 11, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants