Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add co-located repo hint to Gerrit question #2956

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

prattmic
Copy link
Contributor

@prattmic prattmic commented Feb 5, 2024

Working with Gerrit requires directly invoking git commands, which is awkward without a co-located repo. Add a hint to use a co-located repo.

This is something I tripped over. it was unclear from the instructions whether or not I should use jj git push or underlying git).

This becomes irrelevant if #2845 is merged.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

Working with Gerrit requires directly invoking git commands, which is awkward
without a co-located repo. Add a hint to use a co-located repo.
@prattmic
Copy link
Contributor Author

prattmic commented Feb 5, 2024

cc @PhilipMetzger @thoughtpolice

Copy link
Contributor

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for expanding the missing detail.

@PhilipMetzger PhilipMetzger merged commit f877dfb into jj-vcs:main Feb 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants