test_abandon_command: create another test for bug 2600
#2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branches move around a little confusigly with `abandon`. We do want to keep them, to test their behavior, but we can show the change id to make things clearer.
ilyagr
changed the title
test_abandon_command: create another test for #2600test_abandon_command: create another test for bug 2600
ilyagr
force-pushed
the
abandontest
branch
2 times, most recently
from
7b70e7a to
966ab06
Compare
See comments inline for details. Cc jj-vcs#2600. In particular, I wanted to make sure these behaviors are not affected by jj-vcs#2646. They don't seem to be. The tests ended up weirder than expected because of jj-vcs#2600 (comment). Even though, right now, the behavior of tests is unaffected by that issue, the *expected* behavior is different.
3 tasks
martinvonz
approved these changes
Dec 1, 2023
4 tasks
martinvonz
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments inline for details.
The tests ended up weirder than expected because
of #2600 (comment). Even though,
right now, the behavior of tests is unaffected by that issue, the expected behavior is different.
In particular, I wanted to make sure these behaviors are not affected by #2646.
They don't seem to be.
Checklist
If applicable:
CHANGELOG.md