repo: add merge methods per ref kind, remove RefName indirection #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MutableRepo handles merging of the other kind of refs internally, and the merge function is short enough to inline. I also removed early returns since most callers provide non-identical ref targets, and merge_ref_targets() should be cheap if the inputs can be trivially merged.
This prepares for the removal of merge_single_refs().
Since local/remote branches are now of different types, it doesn't make much sense to dispatch merging through RefName. Let's add merge_<kind>() methods instead.
It's no longer used by View API.
martinvonz
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md