Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix undo of "branch track/untrack" to merge state changes #2412

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Oct 21, 2023

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

yuja added 3 commits October 22, 2023 06:57
This partially reverts the change in 30fb799 "view: make local/remote
branches iterator yield RemoteRef instead of RefTarget." As I'm going to add
diff function for RemoteRef pairs, we'll need a generic version of merge-join
iterator anyway.
I'm going to add RemoteRef variant of this function, and "refs" there will
be ambiguous.
lib/src/refs.rs Outdated Show resolved Hide resolved
Otherwise "jj op undo" can't roll back tracking states (whereas "op restore"
can.)
@yuja yuja force-pushed the push-ywsrmqxksnzm branch from 8880996 to 0b04910 Compare October 23, 2023 21:57
@yuja yuja merged commit 5543f7a into jj-vcs:main Oct 23, 2023
14 checks passed
@yuja yuja deleted the push-ywsrmqxksnzm branch October 23, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants