Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract StringPattern to module, add glob: pattern to be used in CLI #2407

Merged
merged 4 commits into from
Oct 21, 2023
Merged

extract StringPattern to module, add glob: pattern to be used in CLI #2407

merged 4 commits into from
Oct 21, 2023

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Oct 20, 2023

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

martinvonz
martinvonz approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

@yuja yuja merged commit cfcc765 into jj-vcs:main Oct 21, 2023
14 checks passed
@yuja yuja deleted the push-vmontrkptuzx branch October 21, 2023 00:55
@martinvonz martinvonz mentioned this pull request Feb 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonz martinvonz martinvonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuja @martinvonz