fix: run 'cargo test' under 'nix flake check' with a non-debug profile #2340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The Nix CI has been failing recently due to (what I assume is) disk space issues. But only the `flake check` step is failing. Right now, `nix flake check` runs the Cargo tests with the debug profile to help get more debug info, which is even heftier in terms of debug info than the normal 'test' profile. For reference, a single build of 'cargo test' in a clean working copy results in a 15 gigabyte `target/` directory. Turn off the debug profile for `nix flake check`, which should hopefully stem the bleeding a bit. I believe the 'test' profile should still have enough symbols for backtraces, so panics should still be useful. Signed-off-by: Austin Seipp <[email protected]> Change-Id: Idde10ac15847a1ad1e6f4e48a2497eca
martinvonz
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The Nix CI has been failing recently due to (what I assume is) disk space issues. But only the
flake checkstep is failing. Right now,nix flake checkruns the Cargo tests with the debug profile to help get more debug info, which is even heftier in terms of debug info than the normal 'test' profile. For reference, a single build of 'cargo test' in a clean working copy results in a 15 gigabytetarget/directory.Turn off the debug profile for
nix flake check, which should hopefully stem the bleeding a bit. I believe the 'test' profile should still have enough symbols for backtraces, so panics should still be useful.Change-Id: Idde10ac15847a1ad1e6f4e48a2497eca
Checklist
If applicable:
CHANGELOG.md