git: prep for importing refs/heads/* as @git remote branches
#2309
Conversation
…te refs If we made @git branches real .remote_targets["git"], remotely-rewritten commits could also be pinned by the @git branches, and therefore wouldn't be abandoned. We could exclude the "git" remote, but I don't think local commits should be pinned by remote refs in general. If we squashed a fetched commit, remote ref would point to a hidden commit anyway.
I'll probably reorganize the local/remote branches structure, so let's minimize call sites which rely on the BranchTarget struct.
There aren't many callers, but let's add it for consistency.
There was a problem hiding this comment.
Looks good! Thanks, Yuya!
On a related note, I'd like to have a chance to understand the plan to "importing refs/heads/* as @git remote branches" before we entirely commit to it. I'm assuming this is related to #2304. I hope this won't introduce much of a delay; if it does I guess I'll just have to step aside and think about it after the fact.
Yes. The first half will just copy Thanks for the review. |
Checklist
If applicable:
CHANGELOG.md