Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nix): add 'default' features to list of cargo features #2238

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

thoughtpolice
Copy link
Member

@thoughtpolice thoughtpolice commented Sep 8, 2023

Summary: By default, and to be explicit, the local flake turns off default features. But, 70f6e0a turned off watchman support for the Nix build by accident. Enable default features so this doesn't happen again.

Change-Id: Ib7dd935eceab328fa5b0333b10368377

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

Summary: By default, and to be explicit, the local flake turns off default
features. But, 70f6e0a turned off watchman support for the Nix build by
accident. Enable default features so this doesn't happen again.

Signed-off-by: Austin Seipp <[email protected]>
Change-Id: Ib7dd935eceab328fa5b0333b10368377
@thoughtpolice thoughtpolice merged commit 2e8b824 into main Sep 9, 2023
@thoughtpolice thoughtpolice deleted the push-uxsxvyynlpnw branch September 9, 2023 00:38
@thoughtpolice thoughtpolice restored the push-uxsxvyynlpnw branch September 9, 2023 00:38
@thoughtpolice thoughtpolice deleted the push-uxsxvyynlpnw branch September 9, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants